Implemented instance type - #712
Merged
Merged
Conversation
ekharkunov
commented
Apr 24, 2025
| this.remoteEngineBuilder.buildAsync(remoteInstanceConfig, uploadDirectory, platform, sdkVersion, jobDirectory, buildDirectory, metricsWriter); | ||
| } else { | ||
|
|
||
| if (instanceType.equals(InstanceType.BUILDER_ONLY)) { |
Contributor
Author
There was a problem hiding this comment.
If instance marked as "BUILDER_ONLY" - skip request for sdk mappings and start building.
| try { | ||
| // sdk version was removed (dev or beta) | ||
| buildEnvDescription = ExtenderUtil.getSdksForPlatform(platform, defoldSdkService.getPlatformSdkMappings(sdkVersion)); | ||
| } catch(ExtenderException exc) { |
Contributor
Author
There was a problem hiding this comment.
Exception happened if we can't find sdk mappings for given hash.
| LOGGER.info("Building engine on remote builder"); | ||
| RemoteInstanceConfig remoteInstanceConfig = getRemoteBuilderConfig(buildEnvDescription[0], buildEnvDescription[1]); | ||
| this.remoteEngineBuilder.buildAsync(remoteInstanceConfig, uploadDirectory, platform, sdkVersion, jobDirectory, buildDirectory, metricsWriter); | ||
| } else if (instanceType.equals(InstanceType.MIXED)) { |
Contributor
Author
There was a problem hiding this comment.
If sdk mappings exist but there are no required sdk version defined and instance marked as "MIXED" - try build on current instance.
| asyncBuilder.asyncBuildEngine(metricsWriter, platform, sdkVersion, jobDirectory, uploadDirectory, buildDirectory); | ||
| } else { | ||
| // no remote buidler was found and current instance can't build | ||
| throw new NotSupportedException("Engine version unsupported. Please, update engine to the newer version."); |
Contributor
Author
There was a problem hiding this comment.
SDK mappings exists but no record for given sdk and version was found - throw error.
britzl
reviewed
Apr 25, 2025
britzl
approved these changes
Apr 25, 2025
ekharkunov
marked this pull request as draft
May 1, 2025 08:36
ekharkunov
marked this pull request as ready for review
November 12, 2025 18:37
Summary - Extender code coverage reportSummary
Coveragecom/defold/extender - 26.2%
com/defold/extender/builders - 0%
com/defold/extender/cache - 35.4%
com/defold/extender/cache/info - 100%
com/defold/extender/log - 0%
com/defold/extender/metrics - 7.4%
com/defold/extender/process - 10.4%
com/defold/extender/remote - 0%
com/defold/extender/services - 24.2%
com/defold/extender/services/cocoapods - 50.6%
com/defold/extender/services/data - 80.7%
com/defold/extender/tracing - 0%
com/defold/extender/utils - 0%
|
britzl
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors about unsupported engine's version or platform become more clear.
Fixes #465
Fixes #720
Technical details
Now it's possible to configure instance type explicitly. Depends on instance type Extender define how to handle "non-existed sdk mapping" case.